hacklab/strudel
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #938 from tidalcycles/pianoroll-sorting

Browse source 
fix: pianoroll sorting
This commit is contained in:
Felix Roos 2024-01-24 16:48:57 +01:00 • committed by GitHub
commit dd64bf0fc9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
packages/core/pianoroll.mjs
View file

@ -160,8 +160,13 @@ export function pianoroll({
maxMidi = max; maxMidi = max;
valueExtent = maxMidi - minMidi + 1; valueExtent = maxMidi - minMidi + 1;
} }
// foldValues = values.sort((a, b) => a - b); foldValues = values.sort((a, b) =>
foldValues = values.sort((a, b) => String(a).localeCompare(String(b))); typeof a === 'number' && typeof b === 'number'
? a - b
: typeof a === 'number'
? 1
: String(a).localeCompare(String(b)),
);
barThickness = fold ? valueAxis / foldValues.length : valueAxis / valueExtent; barThickness = fold ? valueAxis / foldValues.length : valueAxis / valueExtent;
ctx.fillStyle = background; ctx.fillStyle = background;
ctx.globalAlpha = 1; // reset! ctx.globalAlpha = 1; // reset!