hacklab/strudel
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat: support n for voicing scales

Browse source 
+ simplify voicing logic
This commit is contained in:
Felix Roos 2023-07-09 22:11:40 +02:00
parent 36fa9d81fb
commit d5c0309885
3 changed files with 31 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

4
packages/tonal/voicings.mjs
View file

@ -139,13 +139,13 @@ export const rootNotes = register('rootNotes', function (octave, pat) {
export const voicing = register('voicing', function (dictionary, pat) {
return pat
.fmap((value) => {
let { voiceMax: max, voiceBelow: below, voiceOffset: offset, chord, ...rest } = value;
let { voiceMax: max, voiceBelow: below, voiceOffset: offset, chord, n, ...rest } = value;
let top = max || below;
top = top?.note || top || 'c5';
if (typeof dictionary === 'string') {
dictionary = voicingRegistry[dictionary]?.dictionary;
}
let notes = voiceBelow(top, chord, dictionary, offset);
let notes = voiceBelow(top, chord, dictionary, offset, n);
if (below) {
notes = notes.filter((n) => note2midi(n) !== note2midi(top));
}