hacklab/strudel
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(midi): ensure midin initializes device state correctly

Browse source 
The midin function only initialized the refs object for a device on the initial MIDI setup. This caused an error if a second MIDI device was connected in the same session, as its refs object would not exist, leading to a 'cannot read properties of undefined' error when accessed.

This commit fixes the issue by ensuring that the refs object for a given MIDI input is initialized every time  is called, not just on the first call.
This commit is contained in:
Chandler Abraham 2025-07-22 21:49:40 -07:00
parent b312ff63a9
commit c8cf1dc712
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
packages/midi/midi.mjs
View file

@ -493,6 +493,9 @@ export async function midin(input) {
otherInputs?.length ? `Also available: ${getMidiDeviceNamesString(otherInputs)}` : '' otherInputs?.length ? `Also available: ${getMidiDeviceNamesString(otherInputs)}` : ''
}`, }`,
); );
}
// ensure refs for this input are initialized
if (!refs[input]) {
refs[input] = {}; refs[input] = {};
} }
const cc = (cc) => ref(() => refs[input][cc] || 0); const cc = (cc) => ref(() => refs[input][cc] || 0);