hacklab/strudel
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[perf] fix phaser leak of unused biquads

Browse source
This commit is contained in:
jeromew 2025-11-29 14:47:03 +00:00
parent 7a3e0fd3fe
commit b65cc2128f
1 changed files with 3 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

9
packages/superdough/superdough.mjs
View file

@ -290,7 +290,7 @@ function getPhaser(time, end, frequency = 1, depth = 0.5, centerFrequency = 1000
const lfo = getLfo(ac, time, end, { frequency, depth: sweep * 2 }); const lfo = getLfo(ac, time, end, { frequency, depth: sweep * 2 });
//filters //filters
const numStages = 2; //num of filters in series const numStages = 1; //num of filters in series
let fOffset = 0; let fOffset = 0;
const filterChain = []; const filterChain = [];
for (let i = 0; i < numStages; i++) { for (let i = 0; i < numStages; i++) {
@ -302,12 +302,9 @@ function getPhaser(time, end, frequency = 1, depth = 0.5, centerFrequency = 1000
lfo.connect(filter.detune); lfo.connect(filter.detune);
fOffset += 282; fOffset += 282;
if (i > 0) {
filterChain[i - 1].connect(filter);
}
filterChain.push(filter); filterChain.push(filter);
} }
return { phaser: filterChain[filterChain.length - 1], lfo }; return { phaser: filterChain, lfo };
} }
function getFilterType(ftype) { function getFilterType(ftype) {
@ -699,7 +696,7 @@ export const superdough = async (value, t, hapDuration, cps = 0.5, cycle = 0.5)
if (phaserrate !== undefined && phaserdepth > 0) { if (phaserrate !== undefined && phaserdepth > 0) {
const { phaser, lfo } = getPhaser(t, endWithRelease, phaserrate, phaserdepth, phasercenter, phasersweep); const { phaser, lfo } = getPhaser(t, endWithRelease, phaserrate, phaserdepth, phasercenter, phasersweep);
audioNodes.push(lfo); audioNodes.push(lfo);
chain.push(phaser); Array.prototype.push.apply(chain, phaser);
} }
// last gain // last gain