hacklab/strudel
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

- fix scale() to allow both n() and note() at the same time

Browse source 
- fix scale() to allow scale names without tonic and then default it to C
This commit is contained in:
Kaspars 2024-05-07 23:56:39 +02:00
parent 27d8bae671
commit a5b6022506
2 changed files with 17 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

15
packages/tonal/test/tonal.test.mjs
View file

@ -30,6 +30,14 @@ describe('tonal', () => {
.firstCycleValues.map((h) => h.note),
).toEqual(['C3', 'D3', 'E3']);
});
it('scale with n and note values', () => {
expect(
n(0, 1, 2)
.note(3, 4, 5)
.scale('C major')
.firstCycleValues.map((h) => h.note),
).toEqual(['F3', 'G3', 'A3']);
});
it('scale with colon', () => {
expect(
n(0, 1, 2)
@ -37,6 +45,13 @@ describe('tonal', () => {
.firstCycleValues.map((h) => h.note),
).toEqual(['C3', 'D3', 'E3']);
});
it('scale without tonic', () => {
expect(
n(0, 1, 2)
.scale('major')
.firstCycleValues.map((h) => h.note),
).toEqual(['C3', 'D3', 'E3']);
});
it('scale with mininotation colon', () => {
expect(
n(0, 1, 2)