hacklab/strudel
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: cut glitches due to envelope release trouble

Browse source
This commit is contained in:
Felix Roos 2023-03-15 22:42:03 +01:00
parent 7b529a30f4
commit 8a22c5627a
2 changed files with 12 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

9
packages/webaudio/helpers.mjs
View file

@ -27,12 +27,15 @@ export const getEnvelope = (attack, decay, sustain, release, velocity, begin) =>
return {
node: gainNode,
stop: (t) => {
gainNode.gain.setValueAtTime(sustain * velocity, t);
if (typeof gainNode.gain.cancelAndHoldAtTime === 'function') {
gainNode.gain.cancelAndHoldAtTime(t);
} else {
// firefox: this will glitch when the sustain has not been reached yet at the time of release
gainNode.gain.setValueAtTime(sustain * velocity, t);
}
gainNode.gain.linearRampToValueAtTime(0, t + release);
},
};
// gainNode.gain.linearRampToValueAtTime(0, end + release); // release
// return gainNode;
};
export const getADSR = (attack, decay, sustain, release, velocity, begin, end) => {