Fix Bjorklund (#343)

* port Rohan Drape's Bjorklund implementation, add Toussaint's tests
* fix euclidLegato, simplifying a bit now that bjork results should always begin with an 'on'
* migrate euclid numbers in tunes
- 3,4 +1
- 5,8 -1
- 6,8 +3

Co-authored-by: Felix Roos <flix91@gmail.com>

packages/core/euclid.mjs

@@ -1,14 +1,59 @@
 /*
-euclid.mjs - <short description TODO>
-Copyright (C) 2022 Strudel contributors - see <https://github.com/tidalcycles/strudel/blob/main/packages/core/euclid.mjs>
+euclid.mjs - Bjorklund/Euclidean/Diaspora rhythms
+Copyright (C) 2023 Rohan Drape and strudel contributors
+
+See <https://github.com/tidalcycles/strudel/blob/main/packages/core/euclid.mjs> for authors of this file.
+
+The Bjorklund algorithm implementation is ported from the Haskell Music Theory Haskell module by Rohan Drape -
+https://rohandrape.net/?t=hmt
+
 This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU Affero General Public License for more details. You should have received a copy of the GNU Affero General Public License along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
 
-import { Pattern, timeCat, register } from './pattern.mjs';
-import bjork from 'bjork';
-import { rotate } from './util.mjs';
+import { Pattern, timeCat, register, silence } from './pattern.mjs';
+import { rotate, flatten } from './util.mjs';
 import Fraction from './fraction.mjs';
 
+const splitAt = function (index, value) {
+  return [value.slice(0, index), value.slice(index)];
+};
+
+const zipWith = (f, xs, ys) => xs.map((n, i) => f(n, ys[i]));
+
+const left = function (n, x) {
+  const [ons, offs] = n;
+  const [xs, ys] = x;
+  const [_xs, __xs] = splitAt(offs, xs);
+  return [
+    [offs, ons - offs],
+    [zipWith((a, b) => a.concat(b), _xs, ys), __xs],
+  ];
+};
+
+const right = function (n, x) {
+  const [ons, offs] = n;
+  const [xs, ys] = x;
+  const [_ys, __ys] = splitAt(ons, ys);
+  const result = [
+    [ons, offs - ons],
+    [zipWith((a, b) => a.concat(b), xs, _ys), __ys],
+  ];
+  return result;
+};
+
+const _bjork = function (n, x) {
+  const [ons, offs] = n;
+  return Math.min(ons, offs) <= 1 ? [n, x] : _bjork(...(ons > offs ? left(n, x) : right(n, x)));
+};
+
+const bjork = function (ons, steps) {
+  const offs = steps - ons;
+  const x = Array(ons).fill([1]);
+  const y = Array(offs).fill([0]);
+  const result = _bjork([ons, offs], [x, y]);
+  return flatten(result[1][0]).concat(flatten(result[1][1]));
+};
+
 /**
  * Changes the structure of the pattern to form an euclidean rhythm.
  * Euclidian rhythms are rhythms obtained using the greatest common
@@ -86,7 +131,7 @@ import Fraction from './fraction.mjs';
  */
 
 const _euclidRot = function (pulses, steps, rotation) {
-  const b = bjork(steps, pulses);
+  const b = bjork(pulses, steps);
   if (rotation) {
     return rotate(b, -rotation);
   }
@@ -94,11 +139,11 @@ const _euclidRot = function (pulses, steps, rotation) {
 };
 
 export const euclid = register('euclid', function (pulses, steps, pat) {
-  return pat.struct(_euclidRot(steps, pulses, 0));
+  return pat.struct(_euclidRot(pulses, steps, 0));
 });
 
 export const { euclidrot, euclidRot } = register(['euclidrot', 'euclidRot'], function (pulses, steps, rotation, pat) {
-  return pat.struct(_euclidRot(steps, pulses, rotation));
+  return pat.struct(_euclidRot(pulses, steps, rotation));
 });
 
 /**
@@ -111,14 +156,16 @@ export const { euclidrot, euclidRot } = register(['euclidrot', 'euclidRot'], fun
  */
 
 const _euclidLegato = function (pulses, steps, rotation, pat) {
+  if (pulses < 1) {
+    return silence;
+  }
   const bin_pat = _euclidRot(pulses, steps, rotation);
-  const firstOne = bin_pat.indexOf(1);
-  const gapless = rotate(bin_pat, firstOne)
+  const gapless = bin_pat
     .join('')
     .split('1')
     .slice(1)
     .map((s) => [s.length + 1, true]);
-  return pat.struct(timeCat(...gapless)).late(Fraction(firstOne).div(steps));
+  return pat.struct(timeCat(...gapless));
 };
 
 export const euclidLegato = register(['euclidLegato'], function (pulses, steps, pat) {

packages/core/package.json

@@ -25,7 +25,6 @@
   },
   "homepage": "https://strudel.tidalcycles.org",
   "dependencies": {
-    "bjork": "^0.0.1",
     "fraction.js": "^4.2.0"
   },
   "gitHead": "0e26d4e741500f5bae35b023608f062a794905c2"

packages/mini/test/mini.test.mjs

@@ -79,6 +79,40 @@ describe('mini', () => {
   it('supports patterning euclidean rhythms', () => {
     expect(minS('[a(<3 5>, <8 16>)]*2')).toEqual(minS('a(3,8) a(5,16)'));
   });
+  it("reproduces Toussaint's example euclidean algorithms", () => {
+    const checkEuclid = function (spec, target) {
+      expect(minS(`x(${spec[0]},${spec[1]})`)).toEqual(minS(target));
+    };
+    checkEuclid([1, 2], 'x ~');
+    checkEuclid([1, 3], 'x ~ ~');
+    checkEuclid([1, 4], 'x ~ ~ ~');
+    checkEuclid([4, 12], 'x ~ ~ x ~ ~ x ~ ~ x ~ ~');
+    checkEuclid([2, 5], 'x ~ x ~ ~');
+    // checkEuclid([3, 4], "x ~ x x"); // Toussaint is wrong..
+    checkEuclid([3, 4], 'x x x ~'); // correction
+    checkEuclid([3, 5], 'x ~ x ~ x');
+    checkEuclid([3, 7], 'x ~ x ~ x ~ ~');
+    checkEuclid([3, 8], 'x ~ ~ x ~ ~ x ~');
+    checkEuclid([4, 7], 'x ~ x ~ x ~ x');
+    checkEuclid([4, 9], 'x ~ x ~ x ~ x ~ ~');
+    checkEuclid([4, 11], 'x ~ ~ x ~ ~ x ~ ~ x ~');
+    // checkEuclid([5, 6], "x ~ x x x x"); // Toussaint is wrong..
+    checkEuclid([5, 6], 'x x x x x ~'); // correction
+    checkEuclid([5, 7], 'x ~ x x ~ x x');
+    checkEuclid([5, 8], 'x ~ x x ~ x x ~');
+    checkEuclid([5, 9], 'x ~ x ~ x ~ x ~ x');
+    checkEuclid([5, 11], 'x ~ x ~ x ~ x ~ x ~ ~');
+    checkEuclid([5, 12], 'x ~ ~ x ~ x ~ ~ x ~ x ~');
+    // checkEuclid([5, 16], "x ~ ~ x ~ ~ x ~ ~ x ~ ~ x ~ ~ ~ ~");  // Toussaint is wrong..
+    checkEuclid([5, 16], 'x ~ ~ x ~ ~ x ~ ~ x ~ ~ x ~ ~ ~'); // correction
+    // checkEuclid([7, 8], "x ~ x x x x x x"); // Toussaint is wrong..
+    checkEuclid([7, 8], 'x x x x x x x ~'); // Correction
+    checkEuclid([7, 12], 'x ~ x x ~ x ~ x x ~ x ~');
+    checkEuclid([7, 16], 'x ~ ~ x ~ x ~ x ~ ~ x ~ x ~ x ~');
+    checkEuclid([9, 16], 'x ~ x x ~ x ~ x ~ x x ~ x ~ x ~');
+    checkEuclid([11, 24], 'x ~ ~ x ~ x ~ x ~ x ~ x ~ ~ x ~ x ~ x ~ x ~ x ~');
+    checkEuclid([13, 24], 'x ~ x x ~ x ~ x ~ x ~ x ~ x x ~ x ~ x ~ x ~ x ~');
+  });
   it('supports the ? operator', () => {
     expect(
       mini('a?')