hacklab/strudel
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Move device lookup inside input wrapper

Browse source
This commit is contained in:
Nick Matantsev 2025-12-25 18:38:55 -05:00
parent 213edfb211
commit 47557cf06f
1 changed files with 12 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

22
packages/midi/midi.mjs
View file

@ -481,11 +481,18 @@ class MidiInput {
/** /**
* *
* @param {string | number} input MIDI device name or index defaulting to 0 * @param {string | number} input MIDI device name or index defaulting to 0
* @param {WebMidi.MIDIInput | undefined} device MIDI input device instance (or empty to use as placeholder)
*/ */
constructor(device) { constructor(input) {
const device = getDevice(input, WebMidi.inputs);
if (!device) {
throw new Error(
`midiin: device "${input}" not found.. connected devices: ${getMidiDeviceNamesString(WebMidi.inputs)}`,
);
}
this.id = device.id; this.id = device.id;
this.name = device.name; this.name = device.name;
this.device = device;
this._refs = {}; this._refs = {};
this._refsByChan = {}; this._refsByChan = {};
@ -572,15 +579,10 @@ export async function midin(input) {
); );
} }
const initial = await enableWebMidi(); // only returns on first init const initial = await enableWebMidi(); // only returns on first init
const device = getDevice(input, WebMidi.inputs);
if (!device) {
throw new Error(
`midiin: device "${input}" not found.. connected devices: ${getMidiDeviceNamesString(WebMidi.inputs)}`,
);
}
const instance = midiInputs[device.id] || new MidiInput(device); const instance = midiInputs[input] || new MidiInput(input);
midiInputs[device.id] = instance; midiInputs[input] = instance;
const device = instance.device;
if (initial) { if (initial) {
const otherInputs = WebMidi.inputs.filter((o) => o.name !== device.name); const otherInputs = WebMidi.inputs.filter((o) => o.name !== device.name);