hacklab/strudel
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix midibend and miditouch

Browse source
This commit is contained in:
nkymut 2025-01-25 03:27:46 +08:00
parent e19d059c0f
commit 3189b365c8
2 changed files with 7 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

12
packages/midi/midi.mjs
View file

@ -163,8 +163,6 @@ Pattern.prototype.midi = function (output) {
sysexdata,
} = hap.value;
console.log('hap', hap.value);
velocity = gain * velocity;
// note off messages will often a few ms arrive late, try to prevent glitching by subtracting from the duration length
@ -267,18 +265,20 @@ Pattern.prototype.midi = function (output) {
// Handle midibend
if (midibend !== undefined) {
if (typeof midibend !== 'number' || midibend < 1 || midibend > -1) {
if (typeof midibend == 'number' || midibend < 1 || midibend > -1) {
device.sendPitchBend(midibend, midichan, { time: timeOffsetString });
}else{
throw new Error('expected midibend to be a number between 1 and -1');
}
device.sendPitchBend(midibend, midichan, { time: timeOffsetString });
}
// Handle miditouch
if (miditouch !== undefined) {
if (typeof miditouch !== 'number' || miditouch < 1 || miditouch > 0) {
if (typeof miditouch == 'number' || miditouch < 1 || miditouch > 0) {
device.sendKeyAfterTouch(miditouch, midichan, { time: timeOffsetString });
}else{
throw new Error('expected miditouch to be a number between 1 and 0');
}
device.sendKeyAfterTouch(miditouch, midichan, { time: timeOffsetString });
}
// Handle midicmd