hacklab/strudel
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: another dependency array

Browse source
This commit is contained in:
Felix Roos 2023-01-14 10:58:30 +01:00
parent 88684d6d9e
commit 2732d64beb
4 changed files with 217 additions and 209 deletions
Download patch file Download diff file Expand all files Collapse all files

9
packages/react/src/components/MiniRepl.jsx
View file

@ -15,6 +15,11 @@ const getTime = () => getAudioContext().currentTime;
export function MiniRepl({ tune, hideOutsideView = false, enableKeyboard, drawTime, punchcard, canvasHeight = 200 }) {
drawTime = drawTime || (punchcard ? [0, 4] : undefined);
const evalOnMount = !!drawTime;
const drawContext = useCallback(
!!drawTime ? (canvasId) => document.querySelector('#' + canvasId)?.getContext('2d') : null,
[drawTime],
);
const {
code,
setCode,
@ -35,8 +40,8 @@ export function MiniRepl({ tune, hideOutsideView = false, enableKeyboard, drawTi
defaultOutput: webaudioOutput,
editPattern: (pat) => (punchcard ? pat.punchcard() : pat),
getTime,
evalOnMount: !!drawTime,
drawContext: !!drawTime ? (canvasId) => document.querySelector('#' + canvasId)?.getContext('2d') : null,
evalOnMount,
drawContext,
drawTime,
});

2
packages/react/src/hooks/useStrudel.mjs
View file

@ -100,7 +100,7 @@ function useStrudel({
onDraw(pat, -0.001, haps, drawTime);
}
},
[drawTime, onDraw],
[drawContext, drawTime, onDraw],
);
const inited = useRef();