hacklab/strudel
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

make velocity a regular value prop

Browse source
This commit is contained in:
Felix Roos 2024-03-01 18:00:34 +01:00
parent 7d01764a30
commit 1d92ee76b9
9 changed files with 317 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

5
packages/midi/midi.mjs
View file

@ -125,8 +125,9 @@ Pattern.prototype.midi = function (output) {
const timeOffsetString = `+${offset}`;
// destructure value
const { note, nrpnn, nrpv, ccn, ccv, midichan = 1, midicmd } = hap.value;
const velocity = hap.context?.velocity ?? 0.9; // TODO: refactor velocity
let { note, nrpnn, nrpv, ccn, ccv, midichan = 1, midicmd, gain = 1, velocity = 0.9 } = hap.value;
velocity = gain * velocity;
// note off messages will often a few ms arrive late, try to prevent glitching by subtracting from the duration length
const duration = Math.floor((hap.duration.valueOf() / cps) * 1000 - 10);