hacklab/strudel
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

FIXES: TODO in rotateChroma

Browse source
This commit is contained in:
Bernhard Wagner 2023-07-14 13:45:27 +02:00
parent bbb29ebd7c
commit 0fa5832b63
3 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
packages/tonal/test/tonleiter.test.mjs
View file

@ -61,8 +61,7 @@ describe('tonleiter', () => {
});
test('rotateChroma', () => {
expect(rotateChroma(0, 1)).toBe(1);
expect(rotateChroma(0, -1)).toBe(-1); // this is wrong...
//expect(rotateChroma(0, -1)).toBe(11); // <-- TODO
expect(rotateChroma(0, -1)).toBe(11);
expect(rotateChroma(11, 1)).toBe(0);
expect(rotateChroma(11, 13)).toBe(0);
});

3
packages/tonal/tonleiter.mjs
View file

@ -13,7 +13,8 @@ export const pc2chroma = (pc) => {
return pcs.indexOf(letter.toLowerCase()) + rest.reduce((sum, sign) => sum + accs[sign], 0);
};
export const rotateChroma = (chroma, steps) => (chroma + steps) % 12;
export const rotateChroma = (chroma, steps) => ((chroma + steps % 12) + 12) % 12;
export const chroma2pc = (chroma, sharp = false) => {
return (sharp ? sharps : flats)[chroma];